refactor: remove accordion behavior for non-array nodes#91
Merged
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nzakas
approved these changes
Apr 18, 2025
nzakas
left a comment
nzakas
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
Would like another review before merging. @pkerschbaum would love your thoughts on this.
patricktree
approved these changes
Apr 19, 2025
patricktree
left a comment
patricktree
left a comment
Contributor
There was a problem hiding this comment.
LGTM, really good improvement 👍
(in the future we should address the duplication we have here and in other places)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR simplifies the AST tree view by removing the accordion behavior for non-array nodes while maintaining it for array items.
What changes did you make? (Give an overview)
Related Issues
Closes #71
Is there anything you'd like reviewers to focus on?